WIP caching module #39
Conversation
|
(I should note that the caching implementation in here isn't really ready for review yet. Just need some help with tooling.) |
|
Adam, Unfortunately, I'm on my phone only at the moment, and won't be able to take a look at this directly until this evening. However, when I have a problem with a Rails spec that I can't otherwise figure out, I do this: run the spec, then cd into the temporary directory that is that spec's Rails root under fortitude/tmp/specs, then bundle exec rails server and hit the relevant controller action from there. This lets you see the Rails output and HTML output just as you would in a normal app, and is pretty easy. If you have trouble figuring out the exact directory, just rm -rf fortitude/tmp and re-run -- it'll be the only directory there. I'll dig in more when I get home tonight, but hopefully that should give you a start in the mean time! Andrew
|
|
Thanks, very helpful! On Thu, Dec 3, 2015 at 1:06 PM, Andrew Geweke notifications@github.com
Adam Becker |
| @@ -25,6 +25,11 @@ def render(widget_class, template_handler, local_assigns, is_partial, &block) | |||
| end | |||
|
|
|||
| widget = widget_class.new(needed_assigns) | |||
|
|
|||
| if options[:pathname] | |||
| widget.instance_variable_set(:@virtual_path, options[:pathname]) | |||
There was a problem hiding this comment.
In order for ActionView::Helpers::CacheHelper to work properly, the @virtual_path instance variable must be set: https://github.com/rails/rails/blob/215f86c3483cf300b2ccd6d5d8b97f9c9bf547f5/actionview/lib/action_view/helpers/cache_helper.rb#L230
See discussion in template_handler.rb below:
|
@ageweke: ready for your feedback! |
update find_templates monkeypatch for rails 4.2.5.1
|
See an updated PR in #54. |
@ageweke: I could use your help here if you have a second. I'm using the following command to run the tests:
bundle exec rspec spec/rails/cacheable_method_system_spec.rbAnd it seems that there's some sort of error... but instead of logging the error to the console, it appears to get swallowed by the
oop_rails_server.Any ideas? Or is there a better development workflow?