Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit will always suceed #2

Closed
dnlopes opened this issue May 29, 2015 · 1 comment
Closed

commit will always suceed #2

dnlopes opened this issue May 29, 2015 · 1 comment

Comments

@dnlopes
Copy link

dnlopes commented May 29, 2015

Hi,
with your current implementation transaction will always "suceed". At "TpccStatements.java" you have a commit method that catch the SQL Exception. You call this method to commit transaction at "Delivery.java", "NewOrder.java", etc.

However, since you catch the SQL exception inside the commit method, you will always "return 1" at the end of a transaction.

Solution: do not catch SQL exception in "commit" method in "TpccStatements.java" and add the throws signature. This way, you will "return 0/1" properly.

Thanks,
David

@andygrove
Copy link
Contributor

Thanks. This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants