Use Akka IO Unconnected UDP sender. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whats the rational for the change? |
|
Ensures that the underlying unconnected udp resource is cleaned up and reduces the number of allocations by sending directly. |
timechanter
reviewed
Nov 20, 2016
| private val graphitePort = graphiteConfig.getInt("port") | ||
| private val percentiles: Seq[Integer] = Some(graphiteConfig.getIntList("percentiles")).map(_.asScala).getOrElse(Nil) | ||
|
|
||
| private val plaintextEncoder = new GraphitePlaintextEncoder() |
There was a problem hiding this comment.
Why isn't this composable? Will it only work with the PlaintextEncoder?
There was a problem hiding this comment.
Good point. Could make configurable. Since we don't need the pickler at the moment didn't add. Changing this to be specified by configuration would be way to go though.
|
@timechanter renamed sender to be more specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.