removed get_queryset and overide get method in event_details view #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshar-raaj
added a commit
that referenced
this pull request
Sep 10, 2014
removed get_queryset and overide get method in event_details view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main part of implementing get queryset is to know that the event object with show=True or False. This is known by implementing a get_queryset in the current implementation which returns events which has show=True. So if for an event, get_queryset is checking that if the particular event is there in the get_queryset or not, If not we are raising a 404 error(as we dont want to display the event with show=False). As it should not be a part of get_queryset i removed it and override the get method to implement the same