Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add toCronString function #50

Merged
merged 14 commits into from
Dec 23, 2023
Merged

Conversation

mbfakourii
Copy link
Contributor

hi, in this PR, I added a function to convert inputs (such as minutes and seconds) to the cron string.

Also, a test was added for this function and the documentation was improved.

Add `toCronString` function.
Add test for `toCronString`;
Improve `README.md`.
Copy link
Contributor

@isoos isoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is useful, thanks for the PR! Could you please add the few changes, and also bump the version and add a short changelog entry?

README.md Outdated Show resolved Hide resolved
lib/cron.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@isoos isoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, however, I don't think we should have a logo, please, let's remove it.

README.md Outdated Show resolved Hide resolved
@isoos
Copy link
Contributor

isoos commented Dec 23, 2023

Thanks! I'll possibly be a bit of follow-up maintenance on lints, but will publish this shortly.

@isoos isoos merged commit 61fe62d into agilord:master Dec 23, 2023
1 check failed
@mbfakourii mbfakourii deleted the add_cron_string branch December 23, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants