-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add toCronString
function
#50
Conversation
Add `toCronString` function. Add test for `toCronString`; Improve `README.md`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is useful, thanks for the PR! Could you please add the few changes, and also bump the version and add a short changelog entry?
Add logo. Improve `pubspec.yaml`. Bump version. Add entries in `README.md`. Bug fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, however, I don't think we should have a logo, please, let's remove it.
Thanks! I'll possibly be a bit of follow-up maintenance on lints, but will publish this shortly. |
hi, in this PR, I added a function to convert inputs (such as minutes and seconds) to the cron string.
Also, a test was added for this function and the documentation was improved.