Move channel into the subscription #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Nov 30, 2023
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Nov 30, 2023
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Dec 11, 2023
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Dec 11, 2023
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Dec 11, 2023
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Dec 11, 2023
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Dec 12, 2023
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Jan 8, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Jan 10, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Jan 10, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Jan 14, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Similar to ocm-ramen-sample PR[1] move the channel into the subscription kustomization. This is better for users, removing setup and teardown from the deployment steps. Now it is not possible to forget to deploy or remove the channel after testing. This is better for developers, since now we can test multiple VMs concurrently, without dealing with setup and cleanup of shared resources, since VMs do not share the channel. [1] RamenDR/ocm-ramen-samples#41
aglitke
approved these changes
Jan 15, 2024
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Feb 20, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Feb 28, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Feb 29, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Mar 5, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Mar 7, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Mar 7, 2024
Using my repo until the relevant PR[1] is merged. [1] aglitke/ocm-kubevirt-samples#6 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the deployment and make it easier to tests vms concurrently.