Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt: give better response on invalid arguments #4

Open
novaki opened this issue Feb 24, 2014 · 2 comments
Open

Prompt: give better response on invalid arguments #4

novaki opened this issue Feb 24, 2014 · 2 comments

Comments

@novaki
Copy link
Member

novaki commented Feb 24, 2014

The current response is that the sentence is invalid. It is required to mark which argument is invalid and allow the user to correct it.

@novaki
Copy link
Member Author

novaki commented Mar 13, 2014

What response should we give? Alternatives:

  • just say that the sentence contains invalid argument
  • tell which arguments are invalid
  • give a form in which the user can correct the arguments (we already have a D for that). Also highlight the invalid argument values.
  • the prompt should autocomplete the sentence and focus on the first invalid argument and highlight the error.

@novaki
Copy link
Member Author

novaki commented Mar 13, 2014

We chose alternative 3.

hendricha added a commit that referenced this issue Mar 13, 2014
…ts (refs #4)

Advisor now creates arguments if context can not create them, adds erroneous property and message containing the error that happened
Expression now has a no match argument score, equaling 0, its requiredArgumentsPresent function now takes erroneuous arguments to account
ArgumentReaderDialog now now renders both required and erroneous arguments, and shows their value correctly, fixed NonEmpty validator, also error message from advisor is shown for the fields
hendricha added a commit that referenced this issue Mar 14, 2014
hendricha added a commit that referenced this issue Mar 14, 2014
…er (refs #4)

Because this will not just read arguments, but it will also not allow
the user to launch them until the arguments are fixed.
I also changed a ternary related to form.getValues. (It now maps values to
plain objects with a value property before the ternary.)
hendricha added a commit that referenced this issue Mar 14, 2014
…sults (refs #4)

It should do this, so prompt's autocomplete popup will
not suggest erroneous sentences.
(eg. "Del bra mas" should not suggest "Delete branch from mas".)
hendricha added a commit that referenced this issue Mar 14, 2014
…sed by ArgumentFixerDialog (refs #4)

It gets and expression and calls the dialogLauncher's autocomplete on it with all current values of the form.
It also needs the name of the current field that is validated, so BaseField now has a getter for that.
ArgumentFixerDialog now run autoValidate on all its fields after render, instead of manually adding the error message.
ArgumentFixerDialog now has some refactor on how to get the names of arguments it should deal with.
Also now adds an increasing index to the form name, since it is used as a prefix in the field id, wich lead to multiple inputs in several forms having the same id!
hendricha added a commit that referenced this issue Mar 18, 2014
…ontainer (refs #4)

Also removed the integrationtestish unit tests from DialogLauncher, since they are already tested in the Advisor.
hendricha added a commit that referenced this issue Mar 18, 2014
hendricha added a commit that referenced this issue Mar 18, 2014
#4)

This method autocompletes for one certain expression. Will be used by SentenceAutocompleteValidator
hendricha added a commit that referenced this issue Mar 18, 2014
…advisor service (refs #4)

It now calls service only once even if validate and not validateField method was called, and sets or removes error for every relevant field
hendricha added a commit that referenced this issue Mar 18, 2014
…, SentenceAutocompleteValidator now calls this (refs #4)

Advisor can also now deal with errors thrown from sentce validator, these errors should be instance of Consoloid.Interpreter.InvalidArgumentsError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants