Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tcl inputs. #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

stridge-cruxml
Copy link
Contributor

Add tcl inputs to rules_vivado. It is common to require custom tcl between the various stages, to run reports or an additional optimization stage, examine resources etc.

Additionally, this allows the inclusion of bd. To do this:

In vivado GUI, export the board design to a tcl file. Add this line to the bottom of that tcl file:

generate_target all [get_files *${design_name}.bd]

Then add the tcl to pre_synth_tcl in vivado_bitstream. You will also need to generate the wrapper and set that as the top module though.

@stridge-cruxml
Copy link
Contributor Author

Just realized I committed a bunch of auto formatting changes (with black). Happy to revert if you prefer.

Also fix bug with dependency not included.
Copy link
Owner

@agoessling agoessling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this as well. Maybe an unpopular opinion, but I use single quotes and two space indent for my python styled after Google's internal code. I really should add a .pylintrc. Could you please revert the formatting changes and I'll review? It's currently hard to separate formatting from true changes.

Also before merge, could you add an example of including a simple tcl file in examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants