Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Merge “Finds by Country“ and “Finds by State“ #4

Closed
thcyron opened this issue Sep 7, 2010 · 3 comments
Closed

Merge “Finds by Country“ and “Finds by State“ #4

thcyron opened this issue Sep 7, 2010 · 3 comments

Comments

@thcyron
Copy link
Contributor

thcyron commented Sep 7, 2010

What about merging these two tables and have them look like this:

+---------------+------------------+--------+------------+
| COUNTRY       | STATE            | FINDS  | PERCENTAGE |
+---------------+------------------+--------+------------+
| Germany       | Bayern           |     10 |      50.0% |
|               +------------------+--------+------------+
|               | Sachsen          |      5 |      25.0% |
|               +------------------+--------+------------+
|               | Berlin           |      1 |       5.0% |
+---------------+------------------+--------+------------+
| United States | New York         |      2 |      10.0% |
|               +------------------+--------+------------+
|               | Texas            |      1 |       5.0% |
+---------------+------------------+--------+------------+
| Greece                           |      1 |       5.0% |
+---------------+------------------+--------+------------+
@agorf
Copy link
Owner

agorf commented Sep 7, 2010

Good idea. However, this way you don't have a total for countries that have states. Unless we have something like this:

+---------------+------------------+--------+------------+
| COUNTRY       | STATE            | FINDS  | PERCENTAGE |
+---------------+------------------+--------+------------+
| Germany       | Bayern           |     10 |      50.0% |
|               +------------------+--------+------------+
|               | Sachsen          |      5 |      25.0% |
|               +------------------+--------+------------+
|               | Berlin           |      1 |       5.0% |
|               +------------------+--------+------------+
|                                  |     16 |      80.0% |
+---------------+------------------+--------+------------+
| United States | New York         |      2 |      10.0% |
|               +------------------+--------+------------+
|               | Texas            |      1 |       5.0% |
|               +------------------+--------+------------+
|                                  |      3 |      15.0% |
+---------------+------------------+--------+------------+
| Greece                           |      1 |       5.0% |
+---------------+------------------+--------+------------+

What do you think?

@thcyron
Copy link
Contributor Author

thcyron commented Sep 9, 2010

You’re right, this information isn’t present in my table. I quickly hacked your proposal into the code and came up with the following:

Finds by Country and State

I’m not quite sure about this. It makes the table look a little bit complicated. Another idea is to leave the “Finds by Country“ table untouched and have a separate “Finds by State“ table for each country (if the country has states).

@agorf
Copy link
Owner

agorf commented Sep 9, 2010

I think I like your second proposal better. Something like "Finds by State in Germany", "Finds by State in the United States of America" sounds good. :-)

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants