Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop a linting config for orchestration flows #9693

Closed
LuqiPan opened this issue Jul 12, 2024 · 1 comment · Fixed by #9734
Closed

Develop a linting config for orchestration flows #9693

LuqiPan opened this issue Jul 12, 2024 · 1 comment · Fixed by #9734
Assignees
Labels
asyncFlow related to membrane-based replay and upgrade of async functions enhancement New feature or request

Comments

@LuqiPan
Copy link
Contributor

LuqiPan commented Jul 12, 2024

What is the Problem Being Solved?

Without E support in asyncFlow, we (OpCo) should develop a linting config to prevent developers from using E in orchestration flows.

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@LuqiPan LuqiPan added the enhancement New feature or request label Jul 12, 2024
@turadg turadg self-assigned this Jul 15, 2024
This was referenced Jul 17, 2024
mergify bot added a commit that referenced this issue Jul 18, 2024
closes: #9692, #9693

## Description

Sets up a convention for `flows` modules and document in the orchestration README. 

Also makes lint config to test them. The lint config is exported as a shared config that developers can use. I've included it in the same PR to make sure it works with the new convention.

### Security Considerations
none

### Scaling Considerations
none

### Documentation Considerations
Documented the convention in the README. I expect it'll make its way to docs.agoric.com as needed.

### Testing Considerations
nothing special

### Upgrade Considerations
not yet deployed
@turadg turadg changed the title Develop a linting config to prevent E usage in orchestration flows Develop a linting config for orchestration flows Jul 19, 2024
@mhofman mhofman added the asyncFlow related to membrane-based replay and upgrade of async functions label Jul 25, 2024
@mhofman
Copy link
Member

mhofman commented Jul 25, 2024

This should apply to any async flow of possible

@mergify mergify bot closed this as completed in #9734 Aug 12, 2024
@mergify mergify bot closed this as completed in ad1e50e Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asyncFlow related to membrane-based replay and upgrade of async functions enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants