-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain Testing - Single Command Startup #9855
Comments
I opened #10002. The only thing it's maybe missing is logic to ensure the latest
Alternatively, we maybe have a Makefile helper that does |
closes: #9855 ## Description Adds a `pod-readiness.ts` script and documents a single command (`make start`) setup for starship multichain-testing. Reviewers, please pull this down and try something like `make start && yarn test test/basic-flows.test.ts` to verify it's working. ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations Includes updated documentation. ### Testing Considerations Manually tested by author and reviewers. In CI, the starship gh action does this check for us so this script is not needed there. ### Upgrade Considerations n/a
What is the Problem Being Solved?
currently, the multichain testing setup requires multiple commands to start. There is no readiness check to make sure containers are up and running before executing port-forwarding. Sometimes I have to re-run
make port-forward
for it to succeed after the deployment is finished.Description of the Design
implement a readiness script to check the status of containers before runing the
make port-forward
command. Maybe we can modify theMakefile
to integrate this readiness check, allowing for a single command startup process 🚀A lazy makefile target I use is this:
Seen here:
https://github.com/Agoric/dapp-orchestration-basics/tree/dev/orca-v1#multichain-testing-makefile-helpers
Security Considerations
we can just make the readiness check does not introduce any security vulnerabilities, maybe with how container states are verified. This should be minimal since this is a test environment.
Scaling Considerations
the solution should scale well well with different numbers and types of containers too, and should be consistent behavior, mostly.
Test Plan
Upgrade Considerations
document the changes in the
Makefile
and ensure backward compatibility with existing setups. We can change the documentation where relevant as well.The text was updated successfully, but these errors were encountered: