Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #89

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Update readme #89

merged 6 commits into from
Mar 6, 2024

Conversation

samsiegart
Copy link
Contributor

No description provided.

@samsiegart samsiegart requested a review from LuqiPan March 4, 2024 19:30
Copy link

@LuqiPan LuqiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,101 @@
#!/bin/sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question

Just curious, why is this file needed here if it's already in Agoric/agoric-sdk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .vscode/settings.json file that this script produces only applies when it's at the root of the currently opened workspace, so running it from agoric-sdk wouldn't apply the settings to this repo unless they were opened together in the same workspace.

We could point to the agoric-sdk repo and ask people to copy that .vscode/settings.json into this workspace when working with this repo, but it's more convenient to just have it here and allows us to tweak things specific to this repo.

Copy link
Contributor Author

@samsiegart samsiegart Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsiegart samsiegart enabled auto-merge (rebase) March 6, 2024 08:32
@samsiegart samsiegart merged commit a01a6e0 into main Mar 6, 2024
1 check passed
@samsiegart samsiegart deleted the update-readme branch March 6, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants