workflow: change dependencies for merging, clean-up #48
Conversation
|
Ok, I have some doc fixes which warrant a new point release, so I can test this right away. :) |
|
Hmm, the Deken upload didn't work. :( There are no actual packages on Deken, see http://deken.puredata.info/library/pdlua. And trying to install the 0.12.6 version gives me an error:
@ben-wes Help! |
|
The log is also much shorter than the previous one. Looks like none of the artifacts were downloaded, so the upload was empty as well? @ben-wes I have no idea how to fix this, so I'm afraid that I'll have to roll this back unless you can come up with a quick solution. :(( |
|
Also, it seems that the GH release now seems to have the artifacts that are supposed to be uploaded to Deken, but the GH artifacts are missing. What's going on there? |
|
Looking at the workflow, I think that the download step is missing in deken-upload. I should be able to fix this myself. |
|
ah. damn ... sorry - i was sure that i had tested this properly. can also have a look! |
|
Well I committed a fix in rev. 665531f, which seems to work, but now the old, broken upload of 0.12.6 still shows on Deken as well:
Is there a way I can delete the broken package from Deken? |
|
Here's how it looks like on the Deken website:
Note the broken package at the top. It doesn't seem that I can log into Deken to get rid of it? |
|
Hmm, wait, that broken package is actually newer than the proper ones, so that must also have been part of the latest upload. There must still be something iffy in the deken upload action. |
|
yes ... you can go to https://puredata.info/Members/agraef/software/pdlua/0.12.6/ and find all the files there.
the reason that this is happening is because of the source upload. and there are some redundancies now. i can fix this within a few minutes if ok for you! really sorry that i hadn't seen this. problem was that i continued from a state where i tried to make it more elegant ... and i should just have changed that dependency issue. anyway ... on it! |
|
Yes, please do fix, as I don't really have the faintest idea what I'm doing. ;-) I'm going to get another cup of coffee in the meantime. Waiting as fast as I can... |
Thanks, I just got rid of the borked package. Now waiting for your proper fix. No sweat. :) |
|
Should I revert my 665531f commit, or can you work from there? |
|
Well, I can tell that you're working on a Mac, because your #49 dropped a .github/.DS_Store file in there, lol. Can you please remove that? |
|
Oh well, I guess that I can always remove the file in post. |
|
no no, it's gone now after a force push. you should be able to merge now. that's embarrassing. m( |
|
No worries, I noticed that you already fixed it. :) Thanks, mate! I really appreciate you doing a quick hotfix after my plea for help, on a lovely Sunday afternoon. All looking good now:
|
|
BTW, now that 0.12.6 is done and dusted, would you mind reading over the new Signals and graphics tutorial section some time? Whenever you find the time. If you find any inaccuracies or errors, typos, etc., just let me know. |
all good! - i mean, i created the mess in the first place. :)
already read parts of it and really appreciate this! will read all new parts more carefully tonight and give feedback. |
as mentioned in #47 (comment)
this avoids merged artifacts to slip into the github release.