add option to select default language #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawal-d
requested changes
Apr 8, 2020
package.json
Outdated
| "title": "Default Language for new problems", | ||
| "type": "string", | ||
| "default": "", | ||
| "enum": ["", "C", "C++", "Python", "Rust"], |
There was a problem hiding this comment.
I think it's possible to be more explicit than "" - "None" can be better.
companionHandler.js
Outdated
| const defaultLanguage = preferences().get("defaultLanguage"); | ||
| let selectLanguage; | ||
| if(defaultLanguage != "") { | ||
| selectLanguage = new Promise( (resolve) => { |
There was a problem hiding this comment.
Instead of using this useless promise, you can move both the logics within a single promise, and then do the clecking logic defaultLanguage != "" ... inside this single promise. This can also help eliminate the variable selectLanguage.
package.json
Outdated
| "title": "Default Language for new problems", | ||
| "type": "string", | ||
| "default": "", | ||
| "enum": ["", "C", "C++", "Python", "Rust"], |
There was a problem hiding this comment.
Add a description - what this setting does.
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.