Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to all refs on push events (and other small fixes) #3

Merged
merged 3 commits into from
Mar 22, 2016

Conversation

ScottMansfield
Copy link
Contributor

There's three bits to this PR, one of which is more important than the other two:

  1. Ability to listen to any ref in a repository. I needed this because I wanted to use a webhook server to sync a remote repo any time any push happened.
  2. In verbose mode, print the stderr as well as the stdout of the forked process
  3. Small fix to flag code to simplify it and make the -vt flag more symmetric. This is stylistic, so I'd be fine if you don't want it.

As well I created a basic integration test suite to send some sample json through and test the new logic of handling all refs.

@agrison
Copy link
Owner

agrison commented Mar 22, 2016

Hey @ScottMansfield !

I will of course accept directly 😸

Thank you for your PR, and for the basic integration test that I did not have time to create and forgot since 👍

Cheers!

agrison added a commit that referenced this pull request Mar 22, 2016
Listen to all refs on push events (and other small fixes)
@agrison agrison merged commit 5ea5722 into agrison:master Mar 22, 2016
@ScottMansfield
Copy link
Contributor Author

It looks like the CI build failed because the TestMain didn't wait for the server to come up before starting the tests. I'll tinker with that a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants