Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release action user and email #68

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

HKuz
Copy link
Collaborator

@HKuz HKuz commented Sep 11, 2023

This PR updates the username and email in the Python Semantic Release GH action script. The default behavior was to use github-actions@github.com but because it isn't an actual account, it shows as 'Invalid email' / avatar in the repo when it's the latest commit.

The action script has read/write access, but the docs say the username/email need to be associated with the token used (for permissions). I see this as having two options for using the support@agritheory.dev email:

  1. Add the email to the AgriTheory account (go to GitHub Settings -> Emails -> Add email address). I tested this on one of my repos using my associated AgriTheory dev email (vs primary gmail account) and it worked great
  2. Create a separate GitHub account for the support email, give it read/write access to any repo we use it for in the GH action

⚠️ NOTE BEFORE MERGING ⚠️ - merging this PR will likely break the release workflow until the support email is (or is associated with) an actual GH account.

@agritheory
Copy link
Owner

@HKuz I associated the support address with my account. Merging.

@HKuz
Copy link
Collaborator Author

HKuz commented Sep 11, 2023

@agritheory awesome - I'll roll this change into the other repos as well

@agritheory agritheory merged commit 08bc19b into version-14 Sep 11, 2023
6 checks passed
@agritheory agritheory deleted the sem_rel_email branch September 11, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants