Changed JsonParser #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bartimaeusnek
commented
Aug 11, 2020
bartimaeusnek
commented
- From Newtonsoft.Json to System.Text.Json
- Signed testassembly
- Made internals visible to testproject
- Wrote an integration tests
- Repaired broken tests
+ From Newtonsoft.Json to System.Text.Json + Signed testassembly + Made internals visible to testproject + Wrote an integration tests + Repaired broken tests
zivillian
suggested changes
Aug 12, 2020
bartimaeusnek
force-pushed
the
JsonChange
branch
from
cd35d0e
to
480bc3a
Compare
+ Moved key one layer up + Added "GraphiteMetricData" Converter + Fixed MetricDatapointConverter crashing on NULL + Added Unit Test to cover invalid JSON objects
zivillian
reviewed
Aug 12, 2020
zivillian
reviewed
Aug 13, 2020
zivillian
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.