Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math branch #64

Closed
wants to merge 4 commits into from
Closed

Math branch #64

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 21, 2012

Add methods.

Math- added 3 commits June 21, 2012 23:39
};

// push a customized argument
proto.pushArg = function pushArg (arg) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems redundant.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pushArg" method allow users to add graphicsMagick arguments that are not currently supported by node-gm. So users don't have to wait the node-gm support for an argument added by a new graphicsMagick release. They can use "pushArg" method and wait for an official support.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just use .out(arg) directly now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great. thanks.

@aheckmann
Copy link
Owner

This is great. Can you add some tests and update the README to show support for these methods? We also have the gh-pages branch docs that should be updated.

@ghost
Copy link
Author

ghost commented Jun 22, 2012

ok. As soon as I have time, I will add some tests, update the README and the branch docs.

@aheckmann
Copy link
Owner

I merged it. We just need to add docs. Had to rename the size() method b/c we already had that. renamed to rawSize.

@aheckmann aheckmann closed this Jun 26, 2012
@aheckmann aheckmann mentioned this pull request Jun 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant