-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math branch #64
Math branch #64
Conversation
Add support for graphicsMagick.
}; | ||
|
||
// push a customized argument | ||
proto.pushArg = function pushArg (arg) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pushArg" method allow users to add graphicsMagick arguments that are not currently supported by node-gm. So users don't have to wait the node-gm support for an argument added by a new graphicsMagick release. They can use "pushArg" method and wait for an official support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can just use .out(arg)
directly now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's great. thanks.
This is great. Can you add some tests and update the README to show support for these methods? We also have the gh-pages branch docs that should be updated. |
ok. As soon as I have time, I will add some tests, update the README and the branch docs. |
I merged it. We just need to add docs. Had to rename the size() method b/c we already had that. renamed to rawSize. |
Add methods.