Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering: tweak algorithms for better placement of edges #312

Open
ahitrin opened this issue Jun 19, 2022 · 2 comments
Open

Rendering: tweak algorithms for better placement of edges #312

ahitrin opened this issue Jun 19, 2022 · 2 comments
Labels
enhancement
Milestone
Version 0.15

Comments

@ahitrin
Copy link
Owner

ahitrin commented Jun 19, 2022

Current state of rendering of large goal trees is far from perfection. Let's see an example fragment:

render_edges_1

Here, we have a dependency between goals 25 and 28 (selected with a purple color):

render_edges_2

Looks like a green path should look better. Alas, the rendering engine cannot find it. I guess, we could try to use force-based algorithms to tune edge positions after the initial rendering.
@ahitrin ahitrin changed the title Rendering: use force-based algorithms for better placement of edges Rendering: tweak algorithms for better placement of edges Dec 2, 2022
@ahitrin ahitrin added this to the Version 0.14 milestone Apr 17, 2023
@ahitrin ahitrin pinned this issue Sep 17, 2023
@ahitrin
Copy link
Owner Author

ahitrin commented Sep 17, 2023

Current design WIP: https://github.com/ahitrin/SiebenApp-render-playground/blob/main/notebooks/sieben-render.ipynb

ahitrin added a commit that referenced this issue Apr 27, 2024
@ahitrin
Render.split_by_layers: extract connect_to variable #312
423ff0f
ahitrin added a commit that referenced this issue Apr 27, 2024
@ahitrin
Render.candidates_for_new_layer: simplify return value #312
ffc23c5
ahitrin added a commit that referenced this issue Apr 27, 2024
@ahitrin
Render.candidates_for_new_layer: no need to use sorted_goals #312
c9d35e2
ahitrin added a commit that referenced this issue Apr 27, 2024
@ahitrin
test_render: extract tree example into a fixture #312
11e16bd
ahitrin added a commit that referenced this issue Apr 27, 2024
@ahitrin
Add partial logic for new rendering (part 10 from notebook) #312
12c39dd
ahitrin added a commit that referenced this issue Apr 27, 2024
@ahitrin
render_new: add more functions, fix mypy #312
5f0b337
ahitrin added a commit that referenced this issue Apr 27, 2024
@ahitrin
test_render_approval: disable new test for Python 3.12 #312
d20cef8 
Non-critical: we have this test working on other versions.
ahitrin added a commit that referenced this issue Apr 27, 2024
@ahitrin
Fix: use proper check for Python 3.12 #312
22e5456
ahitrin added a commit that referenced this issue May 25, 2024
@ahitrin
Microfix: do not return empty roots field from Renderer #312
89068fa
ahitrin added a commit that referenced this issue Jun 29, 2024
@ahitrin
Introduce render_next.full_render fn #312
bd32f95
ahitrin added a commit that referenced this issue Jun 29, 2024
@ahitrin
Enable algorithm switch in render.GoalsHolder #312
bb2eff3
ahitrin added a commit that referenced this issue Jun 29, 2024
@ahitrin
Provide switch between old and new rendering #312
0542943
ahitrin added a commit that referenced this issue Jun 30, 2024
@ahitrin
Provide node_opts.edge_render in new algorithm #312
80344c8
ahitrin added a commit that referenced this issue Jun 30, 2024
@ahitrin
Inject listener into rendering process, to remove duplication in test #…
1064762 
…312
ahitrin added a commit that referenced this issue Jun 30, 2024
@ahitrin
More detailed logging in test #312
f0b23c4
ahitrin added a commit that referenced this issue Jun 30, 2024
@ahitrin
Invert rows in the new algorithm #312
3ddba17
ahitrin added a commit that referenced this issue Jun 30, 2024
@ahitrin
Prevent ZeroDivisionError in new algorithm #312
07c7719
ahitrin added a commit that referenced this issue Jul 2, 2024
@ahitrin
Fix KeyError in new render #312
de34ce6
ahitrin added a commit that referenced this issue Jul 4, 2024
@ahitrin
Add more type annotations and docs to functions #312
5c044bc
@ahitrin
Copy link
Owner Author

ahitrin commented Jul 4, 2024

This experiment is still in progress. I'll continue in 0.15.

@ahitrin ahitrin modified the milestones: Version 0.14, Version 0.15 Jul 4, 2024
ahitrin added a commit that referenced this issue Jul 4, 2024
@ahitrin
Fix another KeyError in the new algorithm #312
6f49892
ahitrin added a commit that referenced this issue Jul 4, 2024
@ahitrin
Simplify creation of indexed1 #312
3e34104
ahitrin added a commit that referenced this issue Jul 4, 2024
@ahitrin
Do not create intermediate indexed0 coll #312
543f4e0
ahitrin added a commit that referenced this issue Jul 4, 2024
@ahitrin
Do not create intermediate order2 coll #312
8a13644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Version 0.15
Development

No branches or pull requests
1 participant
@ahitrin