Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version hasn't been being bumped when features were added. #13

Closed
G33kDude opened this issue Feb 15, 2015 · 8 comments
Closed

Version hasn't been being bumped when features were added. #13

G33kDude opened this issue Feb 15, 2015 · 8 comments

Comments

@G33kDude
Copy link
Member

No description provided.

@joedf
Copy link
Member

joedf commented Feb 15, 2015

I lost count. :P
How about 0.0.17.21 ?
0 : not stable/full yet
0 : dido
17 : as in 17 working algorithms
21 : approx. number of "sub"-commits for the 17 algorithms

@G33kDude
Copy link
Member Author

¯_(ツ)_/¯ sounds fine to me

On Sun, Feb 15, 2015 at 12:21 PM, Joe DF notifications@github.com wrote:

I lost count.
How about 0.0.17.21 ?
0 : not stable/full yet
0 : dido
17 : as in 17 working algorithms
21 : approx. number of "sub"-commits for the 17 algorithms


Reply to this email directly or view it on GitHub
#13 (comment)
.

@hi5
Copy link
Contributor

hi5 commented Feb 15, 2015

How about moving code that is not fully working yet ((x)tea, ascii85?) to /src-dev/ and only keep properly working funcs in /src/ that way experiments in /src-dev/ don't require a bump in the version number. ❓

joedf added a commit that referenced this issue Feb 15, 2015
@joedf
Copy link
Member

joedf commented Feb 15, 2015

@G33kDude hahha, Alright great 👍
@hi5 hmm good point

joedf added a commit that referenced this issue Feb 15, 2015
@G33kDude
Copy link
Member Author

"version bumb"

Anyways, branches are cheap. Maybe I should work on the installer in a separate branch as well?

@joedf
Copy link
Member

joedf commented Feb 15, 2015

Hmmm... I don't know... What do you think @hi5 ?

@hi5
Copy link
Contributor

hi5 commented Feb 15, 2015

I don't mind if it is developed in the main branch - I haven't tried it yet but evilC has an installer script which may be of use https://github.com/evilC/AHK-Library-Setup

@G33kDude
Copy link
Member Author

Although that looks well thought out, the "put a placeholder #Include script in ProgFiles" is something I'd rather avoid for two reasons. The first is that it'd require administrator (which can be alleviated by putting it into the MyDocs folder), and the second is that it'd require the person to keep their copy of the library in the same spot all the time. This isn't an issue for people who clone repos into a central directory and leave it there, but that's not the average AHK user, I think.

That being said, it made me realize one of the advantages of having a template. That is, when there's a template you can just #Include said template and use the changes live as they happen (without first requiring it to be built again). I think that make.ahk might want to also output a template to the build directory, for this purpose.


We should consider opening another issue for further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants