Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect sourcemap destination #59

Merged
merged 1 commit into from
Dec 17, 2017
Merged

Fix incorrect sourcemap destination #59

merged 1 commit into from
Dec 17, 2017

Conversation

selrond
Copy link
Contributor

@selrond selrond commented Nov 22, 2017

According to the documentation:

To write external source map files, pass a path relative to the destination to sourcemaps.write().

In WPGulp, however, there is this:

.pipe( sourcemaps.write ( styleDestination ) )
.pipe( lineec() ) // Consistent Line Endings for non UNIX systems.
.pipe( gulp.dest( styleDestination ) )

which, if styleDestination is set to './dist/', effectively creates this structure:

dist/
├── dist/
│   └── style.css.map
└── style.css

(notice the double dist/)

I've fixed this by setting the write destination to proper - current folder.

@ahmadawais
Copy link
Owner

Thanks for that. I think it's better if you create a new PR or clean this one up. Looking forward!

@selrond
Copy link
Contributor Author

selrond commented Dec 16, 2017

@ahmadawais will do. However, as you seem quite busy and I'd love to help developing this further, as this (WordPress + Gulp) is currently what I'm working with, would you consider adding me as a maintainer?

@ahmadawais
Copy link
Owner

@selrond you couldn't have asked for it at a better time. Have you seen #61 I just announced the WPGulp 2.0 — hop over there and comment on your ideas and contribute. That's the best way for both of us to get to know each other and work together as things progress i.e. by adding you as a maintainer.

#61

@selrond
Copy link
Contributor Author

selrond commented Dec 16, 2017

@ahmadawais done, ready to be merged

@ahmadawais ahmadawais merged commit 4dbf7b1 into ahmadawais:master Dec 17, 2017
@ahmadawais
Copy link
Owner

Merged! Thanks! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants