Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor changes #6

Closed
wants to merge 13 commits into from
Closed

minor changes #6

wants to merge 13 commits into from

Conversation

waffleboot
Copy link

  • for-range on workers instead of by index
  • make(slice,n) is the same as make(slice,n,n)
  • worker pool config
  • close(channel) as signal instead of sending boolean value
  • delete isActive var and write right into active variable

@@ -106,7 +106,9 @@ func ScheduledJob3(ctx context.Context) {
}

func main() {
Pool = worker.NewWorkerPool(4, 4)
Pool = worker.NewWorkerPool(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it breaks backward code compatibility. We only have two variables here i think we don't need to add config.go it's simple library

@ahmetask ahmetask closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants