React update #115
Merged
React update #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d7f07be and adds a default for host. When a lookup occurs for `$hostname` on my machine, ledfx crashes. I do not keep the hostname of my machine in `/etc/hosts` nor in DNS fed by DHCP leases. ``` Traceback (most recent call last): File "~/.local/bin/ledfx", line 8, in <module> sys.exit(main()) File "~/.local/lib/python3.7/site-packages/ledfx/__main__.py", line 88, in main ledfx = LedFxCore(config_dir = args.config) File "~/.local/lib/python3.7/site-packages/ledfx/core.py", line 42, in __init__ port=port) File "~/.local/lib/python3.7/site-packages/ledfx/http.py", line 26, in __init__ host = socket.gethostbyname(socket.gethostname()) socket.gaierror: [Errno -2] Name or service not known ``` This change will resolve an inconsistency in behavior. While the vast majority of cases resolve `$hostname` to `127.0.0.1`, this may resolve to the DHCP address or not at all, instead, if `/etc/hosts` and the local resolver are set up just right.
Update Docs
…ff easier. working on letting dev server react app communicate with python back end in dev mode
…d prettier configs for formating
…int errors, added . eslint and prettier configs for formating"
…nse on success, still working towards everything working again from the refactor
Add missing command for windows
Revert "auto-detect ip" and add default host
not-matt
reviewed
Jun 24, 2020
There was a problem hiding this comment.
All changes appear good 👍
getting an error on launch:
File "C:\Users\mb\.conda\envs\ledfx\lib\site-packages\yaml\reader.py", line 89, in peek
return self.buffer[self.pointer+index]
IndexError: string index out of range
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\mb\.conda\envs\ledfx\Scripts\ledfx-script.py", line 11, in <module>
load_entry_point('ledfx', 'console_scripts', 'ledfx')()
File "e:\mb\documents\python\ledfx\ledfx\__main__.py", line 88, in main
ledfx = LedFxCore(config_dir = args.config)
File "e:\mb\documents\python\ledfx\ledfx\core.py", line 24, in __init__
self.config["default_presets"] = load_default_presets()
File "e:\mb\documents\python\ledfx\ledfx\config.py", line 95, in load_default_presets
return yaml.safe_load(file)
...
File "C:\Users\mb\.conda\envs\ledfx\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 2184: character maps to <undefined>
explicit utf-8 encoding
not-matt
approved these changes
Jun 24, 2020
…ting, adjusted a static hosting path
…d. cleaning up console.logs
don't know why this helped but now it's displaying properly
Buttons, icons, colours etc
|
I think i got the static files hosting fixed for the react updates finally should be good to merge now @not-matt want to check it out before the merge |
Mattallmighty
added a commit
to Mattallmighty/LedFx-OLD
that referenced
this pull request
Oct 17, 2020
Merge pull request ahodges9#115 from Dakota-Peel/react-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress but its pretty big of a change so might as well start now for people to review