New build scripts for linux #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this breaks our github actions build scripts. Also instead of having to separate scripts, there should be a single script that takes an argument whether we want to be portable or not (like |
raffaem
force-pushed
the
linux_build_scripts
branch
2 times, most recently
from
d9910bb
to
38fc19b
Compare
|
We can default to portable to preserve current workflows |
raffaem
force-pushed
the
linux_build_scripts
branch
2 times, most recently
from
c7f9dd0
to
9aca952
Compare
|
Does this works? |
|
I would have to test in on multiple platforms. Currently I am preparing to release a new version, so I don't want to mess with the build system, I will probably merge this after releasing the new version. |
Yes that sounds good 🙂 |
raffaem
force-pushed
the
linux_build_scripts
branch
2 times, most recently
from
928f07e
to
2c56699
Compare
raffaem
force-pushed
the
linux_build_scripts
branch
2 times, most recently
from
1b704c3
to
10512e4
Compare
raffaem
force-pushed
the
linux_build_scripts
branch
from
10512e4
to
dbb0629
Compare
raffaem
force-pushed
the
linux_build_scripts
branch
from
b4a0bb3
to
7519191
Compare
raffaem
force-pushed
the
linux_build_scripts
branch
from
7519191
to
5c4352d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow either portable build or local build, and clearly document the two.