Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] Make vignettes from tests #2

Open
lrnv opened this issue Oct 30, 2023 · 4 comments
Open

[idea] Make vignettes from tests #2

lrnv opened this issue Oct 30, 2023 · 4 comments

Comments

@lrnv
Copy link

lrnv commented Oct 30, 2023

It looks like your test suite is well build, congratulation. However as I already noted your documentation is lacking.

One good idea would be to transform each of the test files into its own vignette, to give your users a few examples on how things should be done / can be done using your package.

You have 4 test files, each describing and testing a particular functionality of the package. Leverage them to write vignettes, which would include on top of the code runnig the test exemples a few paragraphs each of descriptions of what it does, what it is, where are the relevant references, etc...

@ahudde
Copy link
Owner

ahudde commented Mar 4, 2024

Dear @lrnv,
Thank you very much for this idea! Thanks to your help in other issues, the documentation has already improved a lot. Does this suffices in your eyes?

@lrnv
Copy link
Author

lrnv commented Mar 4, 2024

On the documentation part, yes it is very good. But on R packages, people like to have vignettes: the CRAn references them, and people usually read them more than the docs themselves.

I do not want to consider this a blocker for the package acceptation at JOSS, but I'd rather see this as an opportunity for you to get more attraction. Moreover, this is not a huge work:

  • Take the examples that are already in your documentations
  • Write a bit of context on why and how they work, leveraging, again, your documentation and your own knowledge of your own code.

If you want to postponne, I'd totally understand.

@ahudde
Copy link
Owner

ahudde commented Mar 5, 2024

Dear @lrnv , thank you very much for the advice, and also for your understanding! I will work on it, but I everything goes, potentially after the acceptation.

@lrnv
Copy link
Author

lrnv commented Mar 5, 2024

Fair enough !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants