Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

core-icon-button not working (random src) #29

Closed
embmicro opened this issue Sep 25, 2014 · 3 comments
Closed

core-icon-button not working (random src) #29

embmicro opened this issue Sep 25, 2014 · 3 comments
Labels

Comments

@embmicro
Copy link

I am trying to use the core-icon-button component but the src element inside it is always set to src="assets/core-icon-button/%7B%7Bsrc%7D%7D" no matter what I set it to when I declare it, or if I'm using an icon instead.

If I modify the core-icon-button.html file and remove src={{src}} on line 35, I can get it to work by using the icon attribute.

If I had to guess I would say that src value is coming from some bug and when it's present it overrides everything else.

@ahuth
Copy link
Owner

ahuth commented Sep 26, 2014

Thanks for raising this issue, which is probably related to issue #28. Let me look into this, and if it's the same as #28, I'll close this one. If not, then I'll look into what the problem is.

@embmicro
Copy link
Author

This may be related to alchaplinsky/polymer-rails#15 since I just tried polymer-rails and it has the same issue.

It looks like something is escaping the "{{src}}" string and attempting to find its path.

It also only attacks some names. Changing "src" to "path" in core-icon-button.html fixes the issue.

EDIT: Upon deeper investigation, it looks like "src" and "href" names are affected. I believe this is due to the emcee/lib/emcee/node.rb file but I could be wrong.

@ahuth
Copy link
Owner

ahuth commented Oct 1, 2014

This should be fixed in release 1.0.8. After updating to the new version, you may have to clean out the old assets in any Rails projects that use this. You can do that with rake assets:clean && rake tmp:clear from the project root.

@ahuth ahuth closed this as completed Oct 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants