Remove hanami-router #197
Merged
Remove hanami-router #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PathItem and Operation for a request can be found by calling methods on the Definitnion instance This solves issue #155 (Capture names affects finding definitions for nested routes), but introduces a regression with using multiple variables in one path fragment. The regression is currently only marked with a pending test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathItems and Operations can now be found by calling methods on a Definition.
This simplifies dependencies quite a bit and has no significant performance impact when running only very few paths. However, this will probably have an impact when dealing with a lot of paths (like hundreds).