-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to cancel queries #6
Comments
This is a good idea. For ollama, do you expect that the ollama processing will be canceled as well? I think we can interrupt the connection, but what happens on the Ollama side depends on them, I think. |
I think so? It's written in go so I assume the process is tied to the request context. If not... I'll report a bug upstream. |
That way, the user can cancel the request by killing the buffer. This will, in turn, kill the and cancel HTTP request. I've tested this with Ollama and it appears to kill the underlying request as well. fixes ahyatt#6
Sorry for the delay, this should do the trick. Please use the new |
Hm. So, actually, binding |
I would expect that canceling the query shouldn't result in any more callbacks, though. Is your intuition about this different? |
Specifically, provide a nice way to cancel queries programatically (e.g., from ellama).
This is especially important with, e.g., a local LLM like ollama. I believe it's sufficient to return the
url-request
process buffer, letting the user run something like(let (kill-buffer-query-functions) (kill-buffer my-llm-buffer))
.The text was updated successfully, but these errors were encountered: