Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menufocus-group refactoring #9

Closed
6 tasks
ai opened this issue Feb 23, 2024 · 6 comments
Closed
6 tasks

menufocus-group refactoring #9

ai opened this issue Feb 23, 2024 · 6 comments

Comments

@ai
Copy link
Owner

ai commented Feb 23, 2024

  • Rename menuKeyUX to focusGroupKeyUX with all files and tests
  • Add role="listbox" support in additional to role="menu"
  • Add role="tablist" support in additional to role="menu"
  • Add role="toolbar" support with horizontal default direction.
  • Add role="menubar" support with horizontal default direction.
  • Update docs to explain listbox and tablist support
@dmitry-kurmanov
Copy link
Contributor

@ai could you please clarify how to run tests in the project?

If I understand it correctly the test command from package.json runs:

  • lint
  • coverage (failed for some reasons)
  • build
  • size-limit

But what about the tests themselves?

image

@ai
Copy link
Owner Author

ai commented Mar 5, 2024

test:coverage script is a script of unit tests. It runs better-node-test, which is a wrapper around node --test.

You need to update Node.js (I recommend latest 20.x).

@dmitry-kurmanov
Copy link
Contributor

I think that the issue might be more complex because of various possible item roles:

  1. menu and menubar require menuitem item role - see the w3c example
  2. listbox requires option item role - the w3c example
  3. tablist require tab item role - example

As for toolbar it might be a problem because it can contains different types of items e.g. button, spinbutton, checkbox, radio etc - the toolbar example

I propose to support menubar, listbox, and tablist within this issue and create a separate one for toolbar.

@ai what do you think?

@ai
Copy link
Owner Author

ai commented Mar 6, 2024

Yes, we can do toolbox in a separated PR

@dmitry-kurmanov
Copy link
Contributor

dmitry-kurmanov commented Mar 6, 2024

@ai here is my draft PR #16 (without toolbox). Can you please look at it?

I have not added new groups to the doc yet. I need some clarifications. Do we want to add all new supported focus group types to the doc?

upd I found the explanation:

Update docs to explain listbox and tablist support

I will update the PR tomorrow

@ai
Copy link
Owner Author

ai commented Jul 19, 2024

Forgot to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants