Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent underscore being used as first character #120

Closed
SteveEdson opened this issue Apr 9, 2019 · 4 comments
Closed

Prevent underscore being used as first character #120

SteveEdson opened this issue Apr 9, 2019 · 4 comments

Comments

@SteveEdson
Copy link
Contributor

I'm trying to use this with PouchDB + CouchDB, however I sometimes get the error:

Only reserved document ids may start with underscore.

I noticed a similar issue was closed a couple of years ago (#28), however I feel like that was due to the request being preference, rather than an actual issue.

Thanks

@ai
Copy link
Owner

ai commented Apr 9, 2019

We can’t just prohibit _ from being first, because it will affect characters distribution and will be bad for security cases.

Seems like it is better to use different alphabet for CouchDB a-zA-Z0-9. Do we need to add it to docs?

@ai ai closed this as completed May 16, 2019
@SteveEdson
Copy link
Contributor Author

Sorry for the delay. Yeah I think it would make sense for this to be highlighted in the docs.

Thanks

@ai
Copy link
Owner

ai commented Jul 16, 2019

@SteveEdson can you check my docs changes? 140b527

@SteveEdson
Copy link
Contributor Author

Just added a comment within the PR, other than that, LGTM 👍. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants