Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.0 regression #53

Closed
oliviertassinari opened this issue Mar 4, 2018 · 3 comments
Closed

v15.0 regression #53

oliviertassinari opened this issue Mar 4, 2018 · 3 comments

Comments

@oliviertassinari
Copy link
Contributor

oliviertassinari commented Mar 4, 2018

I have noticed the following regression upgrading size-limit:

v0.14.1
capture d ecran 2018-03-04 a 22 17 49

v0.15.0
capture d ecran 2018-03-04 a 22 16 58

It could be linked to my configuration. The beginning of the rabbit hole 🐰:

.size-limit

  {
    "name": "The initial cost people pay for using one component",
    "path": "test/size/overhead.js",
    "limit": "25.0 KB"
  },

test/size/overhead.js

import '../../build/Paper';

../../build/Paper/index.js

'use strict';

Object.defineProperty(exports, "__esModule", {
  value: true
});

var _Paper = require('./Paper');

Object.defineProperty(exports, 'default', {
  enumerable: true,
  get: function get() {
    return _interopRequireDefault(_Paper).default;
  }
});

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

Any idea?

@ai
Copy link
Owner

ai commented Mar 5, 2018

We found a source and fix is in the master. I will release it tomorrow (sorry, have no power after 9 hours flight).

@oliviertassinari
Copy link
Contributor Author

No rush. It would still be awesome to have this issue fixed in one month from now :).

@ai
Copy link
Owner

ai commented Mar 5, 2018

The fix was released in 0.16.

@ai ai closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants