Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker runs gtc cpu backend #101

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Docker runs gtc cpu backend #101

merged 3 commits into from
Jan 25, 2022

Conversation

elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Jan 21, 2022

Purpose

We cannot run gtc cpu backend in docker currently. This appears to be an issue with the version of grid tools libraries. This PR provides a temporary fix to run pytest with gtc:gt:cpu_ifirst backend.

Infrastructure changes:

  • Pin gridtools version in Dockerfile

Checklist

Before submitting this PR, please make sure:


RUN if [ ! -z `echo $GT4PY_OPTIONALS | grep cuda` ] ; then pip install cupy-cuda102==7.7.0 ; else echo Not installing cuda ; fi
RUN pip install --no-cache-dir -c /constraints.txt "/gt4py${GT4PY_OPTIONALS}" && \
python3 -m gt4py.gt_src_manager install
RUN python -m pip install --no-cache-dir -c /constraints.txt -e "/gt4py${GT4PY_OPTIONALS}"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When installing without -e, on the first gtc backend run, it pulls the wrong version of gridtools again. But having -e skips that step. Unclear about this behavior.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-e is directing the GT source to be install alongside the python source, while without the -e PIP installs into its own directory structure. The issue is that by default the source path is set to the one created by -e.

@FlorianDeconinck
Copy link
Contributor

Another issue is that v36 via the src_manager is pulling GridTools master which is a moving target. Subsequent version of gt4py are pinning v2.1.0. For now, we should revert to installing by hand, for reproducability

@elynnwu elynnwu enabled auto-merge (squash) January 21, 2022 19:21
@elynnwu
Copy link
Collaborator Author

elynnwu commented Jan 21, 2022

launch jenkins

1 similar comment
@elynnwu
Copy link
Collaborator Author

elynnwu commented Jan 21, 2022

launch jenkins

@elynnwu
Copy link
Collaborator Author

elynnwu commented Jan 21, 2022

launch jenkins

5 similar comments
@elynnwu
Copy link
Collaborator Author

elynnwu commented Jan 22, 2022

launch jenkins

@elynnwu
Copy link
Collaborator Author

elynnwu commented Jan 24, 2022

launch jenkins

@elynnwu
Copy link
Collaborator Author

elynnwu commented Jan 24, 2022

launch jenkins

@elynnwu
Copy link
Collaborator Author

elynnwu commented Jan 24, 2022

launch jenkins

@elynnwu
Copy link
Collaborator Author

elynnwu commented Jan 25, 2022

launch jenkins

@elynnwu elynnwu merged commit 0ad03cf into main Jan 25, 2022
@elynnwu elynnwu deleted the fix/docker-gtc-backend branch January 25, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants