Add physics savepoint test #5
Conversation
`gtc:gt:cpu_ifirst` threshold update
… add-physics-savepoint-test
… add-physics-savepoint-test
Reset the grid only if we have multiple ranks Use numpy API to calculate worst error Re-use code for compare_scalar
…Modeling/fv3gfs-integration into add-physics-savepoint-test
…integration into add-physics-savepoint-test
…Modeling/fv3gfs-integration into add-physics-savepoint-test
| "va": {}, | ||
| } | ||
|
|
||
| def collect_input_data(self, serializer, savepoint): |
There was a problem hiding this comment.
All functions except for compute_parallel can be removed once Grid initialization is ready
|
|
||
|
|
||
| # get MPI environment | ||
| sys.path.append("/usr/local/serialbox/python") # noqa: E402 |
There was a problem hiding this comment.
Is this a reliable location for serialbox?
There was a problem hiding this comment.
It isn't, but it is how fv3core has it for now. I think the best solution is to be able to pip install serialbox, otherwise we may want to move to an environment variable for this.
GT4PY_VERSION.txt
Outdated
| v35 |
There was a problem hiding this comment.
Just curious if there are problems in v36?
There was a problem hiding this comment.
This has been tested with v36 for GTC backends, it should be updated
|
Thanks Eddie for reviewing this! This infrastructure is indeed shared across dycore and physics. Our next step will be to move |
Moving/duplicating some of the infrastructure in
fv3coretests up to the integration directory. In this PR, we include savepoint tests for physics only.