Consolidate make_storage_from_shape #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgibbon
approved these changes
Dec 16, 2021
| make_storage_from_shape_uncached( | ||
| shape, origin=origin, init=init, backend=backend | ||
| ) | ||
| make_storage_from_shape(shape, origin=origin, init=init, backend=backend) |
There was a problem hiding this comment.
You can delete this test file - its purpose was to test the caching system, and now that you've deleted it there's no worry that this test would fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we remove the cache version of make storage.
make_storage_from_shape_uncachedis nowmake_storage_from_shape