Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused run_cached_fv_dynamics.sh #95

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Remove unused run_cached_fv_dynamics.sh #95

merged 1 commit into from
Jan 12, 2022

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Jan 12, 2022 •
edited
Loading

Purpose

run_cached_fv_dynamics.sh is a jenkins action we used to use for running parallel tests with a premade cache. Since then, caching has been added to the main infrastructure, and this functionality is duplicated with run_parallel_regression_tests.sh.

This script is not mentioned in any documentation.

Infrastructure changes:

  • run_cached_fv_dynamics.sh is deleted

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@mcgibbon mcgibbon merged commit ac9760c into main Jan 12, 2022
@mcgibbon mcgibbon deleted the feature/remove_run_cached branch January 12, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rheacangeo rheacangeo rheacangeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgibbon @rheacangeo