Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor revisions #41

Merged
merged 7 commits into from
Jan 31, 2022
Merged

Conversation

ClemensBuechner
Copy link
Contributor

I've implemented several minor changes discussed during the code-walk meetings with @FlorianPommerening and @roeger. They don't change anything about the logic but are concerned with renaming stuff for clarification and other minor things to prettify and clean up the code. Here is a list of the changes:

  • Return floating point number when randomly sleeping before submitting jobs to the grid.
  • Replace True if x else False with x.
  • Ensure files are closed after reading/writing.
  • Rename result files on the grid to exit_code and reduce their content to only the exit code without a string that needs to match around it.
  • Rename enforce_order to allow_nondeterministic_successor_choice.

@ClemensBuechner ClemensBuechner merged commit a18a78c into aibasel:main Jan 31, 2022
@ClemensBuechner ClemensBuechner deleted the minor-revisions branch January 31, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant