Modify clumit frontary component #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayeon5470
force-pushed
the
clumit/tableview
branch
3 times, most recently
from
69ac8f5
to
5b62cd2
Compare
Closed
sehkone
reviewed
Jul 2, 2024
sehkone
reviewed
Jul 2, 2024
sehkone
reviewed
Jul 2, 2024
dayeon5470
force-pushed
the
clumit/tableview
branch
2 times, most recently
from
716c9fb
to
b5fa257
Compare
jinjoolee07
force-pushed
the
clumit/tableview
branch
from
b5fa257
to
9235e90
Compare
sehkone
reviewed
Jul 8, 2024
CHANGELOG.md
Outdated
Comment on lines
14
to
18
| - Added Clumit components: `Radio`, `CheckBox`, `TabMenu`, `Modal`. | ||
| - Added `Svg` to fetch and display a SVG file. | ||
| - Added Clumit components: `Sort`, `SelectMini`, `SelectSearchable`, `Input`, | ||
| `view_asterisk`, `Notification`. |
There was a problem hiding this comment.
컴포넌트를 새로 추가한 게 아니라 theme을 추가한 것이니 아래처럼 수정해야 겠네요.
Applied the Clumit theme to `Radio`, `CheckBox`, ...
2f1f3fb
to
85d719e
Compare
sehkone
reviewed
Jul 12, 2024
src/list/whole/view.rs
Outdated
Comment on lines
216
to
219
| if cfg!(feature = "pumpkin-dark") { | ||
| "background-image: url('/frontary/clumit-collapse-list.png');" | ||
| } else { | ||
| "background-image: url('/frontary/collapse-list.png');" | ||
| } | ||
| } else if cfg!(feature = "pumpkin-dark"){ | ||
| "background-image: url('/frontary/clumit-expand-list.png');" | ||
| } else { | ||
| "background-image: url('/frontary/expand-list.png');" | ||
| }; |
There was a problem hiding this comment.
I suggest this:
let prefix = if cfg!(feature = "pumpkin-dark") {
"clumit-"
} else {
""
};
let expand_collapse_img = if self.expand_list.contains(key) {
"collapse-list.png"
} else {
"expand-list.png"
};
let style = format!("background-image: url('/frontary/{prefix}{expand_collapse_img}');");
dayeon5470
force-pushed
the
clumit/tableview
branch
from
85d719e
to
07b6820
Compare
sehkone
approved these changes
Jul 15, 2024
dayeon5470
force-pushed
the
clumit/tableview
branch
from
07b6820
to
2883abb
Compare
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#95
#100
#101
#102