Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI breaking in Forks #401

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix CI breaking in Forks #401

merged 1 commit into from
Sep 14, 2022

Conversation

quackzar
Copy link
Member

Fixes CI breaking for forks due to insufficient permissions.

Fixes CI breaking for forks.
@quackzar quackzar self-assigned this Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #401 (80c3c9b) into master (5944c37) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #401   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      3619      3619           
===========================================
  Files            408       408           
  Lines          10210     10210           
  Branches         777       777           
===========================================
  Hits           10210     10210           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5944c37...80c3c9b. Read the comment docs.

Copy link
Collaborator

@jot2re jot2re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure such extensive permissions are needed?
I don't really know about GitHub actions, but I know that on another project where we are doing the same (code coverage report), it is not needed to set write permissions.
Maybe those yml files can help? https://github.com/TokenScript/attestation/tree/main/.github/workflows

@quackzar
Copy link
Member Author

Are you sure such extensive permissions are needed?
I don't really know about GitHub actions, but I know that on another project where we are doing the same (code coverage report), it is not needed to set write permissions.
Maybe those yml files can help? https://github.com/TokenScript/attestation/tree/main/.github/workflows

I'm not sure, however it seems to be on by default (see here) except in the cases of forks , which is why it fails in the other PR.
The solution I applied here is suggested from the issue #test-reporter/issues/168, however I am not sure if the suggested fix works in our case.

The issue might be solved upstream instead, so we could also disable the test-report either partially for forks or all together.

@jot2re jot2re merged commit 87ce736 into master Sep 14, 2022
@jot2re jot2re deleted the fix-ci-forks branch September 14, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants