Adding a neutron time of flight class #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and example notebook
|
Not best practice but this PR has been merged with the required updates for interpolation, see #22 and branch interp2d_replacement. |
This was
linked to
issues
Apr 2, 2024
|
Happy with the nToF support as written, has literature models for each component up to beamline attenuation (which I can't imagine has a simple model). Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a class for neutron of time of flight analysis with some preliminary support functionality.
While further ntof models can be added in future, the structure of the ntof class is complete. Better instrument response models can be added external to the class.
An example of fitting in time of flight is given in the NeSST guide (with asserts for CI testing).
This has been merged with core_typed_and_documented, so should be merged after #30