Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make sure to correctly attribute MIT license #528

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

AbhiPrasad
Copy link
Contributor

As per the MIT license

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

This means just linking to the direct source code is not good enough.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 0:28am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 0:28am

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Owner

@aidenybai aidenybai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aidenybai aidenybai merged commit 69c9ec6 into aidenybai:main Aug 14, 2023
1 check passed
@AbhiPrasad AbhiPrasad deleted the abhi-credit-mit-license branch August 14, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants