Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 529: Background screen flash on reload #530

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Fix 529: Background screen flash on reload #530

merged 2 commits into from
Aug 15, 2023

Conversation

sshkeda
Copy link
Contributor

@sshkeda sshkeda commented Aug 15, 2023

Please describe the changes this PR makes and why it should be merged:

I followed instructions from https://github.com/pacocoursey/next-themes#without-css-variables to fix flashing. Now instead of seeing a quick white screen flash into your eyes when you open the site, the background will stay dark.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 4:53am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 4:53am

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aidenybai
❌ sshkeda
You have signed the CLA already but the status is still pending? Let us recheck it.

@aidenybai
Copy link
Owner

Nice work! LGTM :)

@aidenybai aidenybai merged commit 898842d into aidenybai:main Aug 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants