-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currency Convertor Added #640
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Please cleanup your code @Roar022 |
From This you mean optimization of code or something else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what @aidenybai meant was for you to remove the many commented code.
Ohh!!, I am really sorry for this mistake. Fixing it right now. |
Awesome! Sure thing. |
40b123d
to
096bf43
Compare
@tobySolutions @aidenybai Please review my changes. If you want any changes, please let me know. |
@Roar022 could you edit your button name from |
1129d65
to
e1dfa79
Compare
Hey there @Roar022! Thank you very much for your PR. You have a duplication though, can you maybe delete one of the files? Screen.Recording.2023-10-04.at.22.37.47.mov |
1fc66ae
to
1d50fc5
Compare
Thank you for your feedback and for reviewing my PR. I apologize for the duplication in the files. I have updated the PR. |
1d50fc5
to
e14b8df
Compare
Pull Request Test Coverage Report for Build 6422880691
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
The exchanged value does not update after the first amount is changed without blurring. The value2 only changes onBlur |
I have added a Currency Convertor using Million.js, Reactjs and Typescript. It allows user to convert one currency to another.
Resolves #604
Status
Semantic versioning classification: