Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency Convertor Added #640

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Conversation

Roar022
Copy link
Contributor

@Roar022 Roar022 commented Oct 2, 2023

I have added a Currency Convertor using Million.js, Reactjs and Typescript. It allows user to convert one currency to another.

Resolves #604

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 6:17pm
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 6:17pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 6:17pm

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

@aidenybai
Copy link
Owner

Please cleanup your code @Roar022

@Roar022
Copy link
Contributor Author

Roar022 commented Oct 2, 2023

Please cleanup your code @Roar022

From This you mean optimization of code or something else?

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what @aidenybai meant was for you to remove the many commented code.

@Roar022
Copy link
Contributor Author

Roar022 commented Oct 3, 2023

I think what @aidenybai meant was for you to remove the many commented code.

Ohh!!, I am really sorry for this mistake. Fixing it right now.

@tobySolutions
Copy link
Contributor

I think what @aidenybai meant was for you to remove the many commented code.

Ohh!!, I am really sorry for this mistake. Fixing it right now.

Awesome! Sure thing.

@Roar022
Copy link
Contributor Author

Roar022 commented Oct 3, 2023

@tobySolutions @aidenybai Please review my changes. If you want any changes, please let me know.

@Timonwa
Copy link
Contributor

Timonwa commented Oct 3, 2023

@Roar022 could you edit your button name from CurrencyConverter to currency-converter, so it can be the same as other buttons?

@tobySolutions
Copy link
Contributor

Hey there @Roar022! Thank you very much for your PR. You have a duplication though, can you maybe delete one of the files?

Screen.Recording.2023-10-04.at.22.37.47.mov

@Roar022
Copy link
Contributor Author

Roar022 commented Oct 4, 2023

Thank you for your feedback and for reviewing my PR. I apologize for the duplication in the files. I have updated the PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6422880691

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6421877308: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tobySolutions tobySolutions merged commit ad6e77f into aidenybai:main Oct 6, 2023
7 checks passed
@elibroftw
Copy link

elibroftw commented Oct 6, 2023

The exchanged value does not update after the first amount is changed without blurring. The value2 only changes onBlur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A Currency Converter
7 participants