Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped the kitchen sink #808

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Revamped the kitchen sink #808

merged 1 commit into from
Oct 31, 2023

Conversation

Drex72
Copy link
Contributor

@Drex72 Drex72 commented Oct 31, 2023

Description of Changes:

In this PR, I have Revamped the Kitchen Sink Website to have better User Experience and to look nicer

Resolves #791

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Additional Note:

The integration of this ESLint plugin is a crucial step in maintaining and improving the quality of our codebase. I believe that it will have a substantial positive impact on our development process, and I am eager to receive feedback and collaborate with the team to ensure a seamless and productive experience. Thank you for considering this PR.

@vercel
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 9:41am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 9:41am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6704683708

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6696930961: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@Drex72
Copy link
Contributor Author

Drex72 commented Oct 31, 2023

@tobySolutions This is the changed and updated revamp without any merge conflicts

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work

@tobySolutions tobySolutions merged commit 70cc57b into aidenybai:main Oct 31, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp the Kitchen Sink Website
3 participants