Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Workflows: Auto Response Workflow #823

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix/Workflows: Auto Response Workflow #823

merged 1 commit into from
Nov 9, 2023

Conversation

haideralipunjabi
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 4:17pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 4:17pm

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6801000106

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on main at 25.706%

Totals Coverage Status
Change from base Build 6800519726: 25.7%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@tobySolutions
Copy link
Contributor

Hey there @haideralipunjabi, you changed it from pull_number to issue.number? May I ask why?

@haideralipunjabi
Copy link
Contributor Author

Hey there @haideralipunjabi, you changed it from pull_number to issue.number? May I ask why?

Sure. The action uses actions/github-script and from its documentation I found out that that context variable doesn't have any property called pull_request, it only has issue as a property.

On studying the actual code of the context variable, you can see that issue.number actually returns both pull request number of issue number based on what is available

@tobySolutions
Copy link
Contributor

Hey there @haideralipunjabi, you changed it from pull_number to issue.number? May I ask why?

Sure. The action uses actions/github-script and from its documentation I found out that that context variable doesn't have any property called pull_request, it only has issue as a property.

On studying the actual code of the context variable, you can see that issue.number actually returns both pull request number of issue number based on what is available

Hmm, thank you very much Haider and the auto labelling issue?

@haideralipunjabi
Copy link
Contributor Author

Hey there @haideralipunjabi, you changed it from pull_number to issue.number? May I ask why?

Sure. The action uses actions/github-script and from its documentation I found out that that context variable doesn't have any property called pull_request, it only has issue as a property.
On studying the actual code of the context variable, you can see that issue.number actually returns both pull request number of issue number based on what is available

Hmm, thank you very much Haider and the auto labelling issue?

Separate PR #824

@tobySolutions
Copy link
Contributor

Hey there @haideralipunjabi, you changed it from pull_number to issue.number? May I ask why?

Sure. The action uses actions/github-script and from its documentation I found out that that context variable doesn't have any property called pull_request, it only has issue as a property.
On studying the actual code of the context variable, you can see that issue.number actually returns both pull request number of issue number based on what is available

Hmm, thank you very much Haider and the auto labelling issue?

Separate PR #824

Oh, ok. I'm gonna merge this to see what happens.

@tobySolutions tobySolutions merged commit 0f9b430 into aidenybai:main Nov 9, 2023
6 of 8 checks passed
Aslemammad pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants