Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rules of Blocks link in FAQ #862

Closed
wants to merge 1 commit into from

Conversation

abduelhamit
Copy link

Please describe the changes this PR makes and why it should be merged:

The link for the Rules of Blocks in the FAQ needs to be fixed. This PR attempts that.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 1:21pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 1:21pm

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@tobySolutions
Copy link
Contributor

Awesome! Thanks @abduelhamit, reviewing it now

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7410072716

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 7394469090: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@tobySolutions
Copy link
Contributor

For some reason @abduelhamit, the FAQ link is not in the header for this your PR and the FAQ page looks very bad, see what I mean below and check out million.dev:

Screenshot 2024-01-05 at 11 22 30 Screenshot 2024-01-05 at 11 22 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants