Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it memoized? #941

Closed
wants to merge 1 commit into from
Closed

is it memoized? #941

wants to merge 1 commit into from

Conversation

mstanton
Copy link

@mstanton mstanton commented Feb 3, 2024

just a suggestion! I'll update when and if I get more info. This project is great. :-)

Please describe the changes this PR makes and why it should be merged:
Memoize and update some conditional logic in compiler/index.ts

Status
Experimental 🥼

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

just a suggestion! :-)
Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 9:09am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 9:09am

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@mstanton mstanton changed the title memoize expensive function calls check for memoize and or expensive function calls Feb 3, 2024
@mstanton mstanton changed the title check for memoize and or expensive function calls is it memoized? Feb 3, 2024
Copy link

github-actions bot commented Feb 6, 2024

Pull Request Test Coverage Report for Build 7765896407

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • -10 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 3.617%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/compiler/index.ts 0 10 0.0%
Totals Coverage Status
Change from base Build 7765582614: 0.007%
Covered Lines: 884
Relevant Lines: 27078

💛 - Coveralls

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Feb 22, 2024
@github-actions github-actions bot closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants