Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #996 Handle property alias #997

Merged
merged 2 commits into from
May 9, 2024

Conversation

AlexanderArvidsson
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Fixes #996.
As this resolves unintended behavior, but technically does change the output of the generated HTML, it is up to you if you want to consider this as a breaking change or not.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 11:43am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 11:43am

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@AlexanderArvidsson
Copy link
Contributor Author

AlexanderArvidsson commented Mar 17, 2024

Compare the difference in the following two Kitchen Sink demos and go to SVG:

Before PR:
https://million-kitchen-sink-git-fork-jahirfiquitiva-patch-1-millionjs.vercel.app

After pr:
https://million-kitchen-sink-git-fork-alexanderarvidss-9f9029-millionjs.vercel.app

This change makes SVGs render correctly, even in your demo :)

@AlexanderArvidsson
Copy link
Contributor Author

I've now fixed the failed test due to linting! Seems my linter wasn't working the first time around; sorry about that!

Copy link

github-actions bot commented Apr 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 5, 2024
@AlexanderArvidsson
Copy link
Contributor Author

Not stale, still waiting for review from @lxsmnsyc, @NisargIO.

@github-actions github-actions bot removed the Stale label Apr 6, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 21, 2024
@AlexanderArvidsson
Copy link
Contributor Author

Not stale

@github-actions github-actions bot removed the Stale label Apr 23, 2024
Copy link

github-actions bot commented May 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label May 9, 2024
@lxsmnsyc lxsmnsyc merged commit 7ff650b into aidenybai:main May 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic compiler renders SVG with invalid props
3 participants