-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #996 Handle property alias #997
fix: #996 Handle property alias #997
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! A maintainer will review it soon.
Compare the difference in the following two Kitchen Sink demos and go to SVG: Before PR: After pr: This change makes SVGs render correctly, even in your demo :) |
I've now fixed the failed test due to linting! Seems my linter wasn't working the first time around; sorry about that! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. |
Not stale |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. |
Please describe the changes this PR makes and why it should be merged:
Fixes #996.
As this resolves unintended behavior, but technically does change the output of the generated HTML, it is up to you if you want to consider this as a breaking change or not.
Status
Semantic versioning classification: