Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rtgs #104

Merged
merged 6 commits into from
Feb 2, 2023
Merged

Adding rtgs #104

merged 6 commits into from
Feb 2, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jan 13, 2023

Description

Summary of changes

  • Added RTGs as a type of power device (that also charges in eclipse)
  • Added test for it, also to check solar doesn't charge in eclipse

Resolved Issues

How Has This Been Tested?

New test, CI

Related Pull Requests

N/A

@gomezzz gomezzz added documentation Improvements or additions to documentation enhancement New feature or request tests Anything related to the tests feature implementing a new feature user-facing Anything that users can interact with physical-model All things involving some physical models labels Jan 13, 2023
@gomezzz gomezzz changed the title Adding rt gs Adding rtgs Jan 13, 2023
@gomezzz gomezzz added the v0.1.0 Related to / Required for v0.1.0 label Jan 30, 2023
@gomezzz gomezzz mentioned this pull request Jan 30, 2023
1 task
Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a typo in the docstring.

import pykep as pk

from paseos.power.power_device_type import PowerDeviceType
from paseos.power.is_in_eclipse import is_in_eclipse


def charge(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the moment or atm instead of amt.

@gomezzz gomezzz merged commit fa97f3e into main Feb 2, 2023
@gomezzz gomezzz deleted the Adding-RTGs branch February 2, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request feature implementing a new feature physical-model All things involving some physical models tests Anything related to the tests user-facing Anything that users can interact with v0.1.0 Related to / Required for v0.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for radioisotope thermoelectic generators (RTG)
2 participants