Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom actor properties #166

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Allow custom actor properties #166

merged 7 commits into from
Jun 22, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jun 15, 2023

Description

Summary of changes

  • Added ability for custom properties
  • Added automatic monitoring of them
  • Added new test for custom properties
  • Small refactoring, reformatting (did we want 100? 127? flake has 127 but that is actually a lot 🤔 )

Resolved Issues

N/A

How Has This Been Tested?

CI/CD, new test

Related Pull Requests

N/A

@gomezzz gomezzz added enhancement New feature or request tests Anything related to the tests feature implementing a new feature user-facing Anything that users can interact with physical-model All things involving some physical models labels Jun 15, 2023
@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Overall Coverage

Coverage Report
FileStmtsMissCoverMissing
paseos
   __init__.py31294%46, 49
   paseos.py1511491%71–72, 144–145, 198, 213, 231, 240, 258, 289, 297–298, 398–399
paseos/activities
   activity_manager.py43393%46, 76, 159
   activity_processor.py58198%123
   activity_runner.py621084%80–84, 104–113, 122–125
paseos/actors
   actor_builder.py1082181%20–24, 27, 119–124, 248, 296, 318, 328–332, 339–340, 345–346
   base_actor.py1211885%82, 99, 115, 153, 193–195, 224, 233, 251, 268, 272–275, 279, 293, 335
   ground_station_actor.py15380%47–53
   spacecraft_actor.py61198%123
paseos/communication
   get_communication_window.py22291%38, 67
   is_in_line_of_sight.py741580%75, 82, 90, 152–169, 213, 233
paseos/power
   charge_model.py17194%54
   discharge_model.py7271%22, 34
   is_in_eclipse.py39490%28–29, 90–91
paseos/tests
   activity_test.py57395%92, 95–96
   communication_window_test.py58198%198
   eclipse_test.py11191%22
   import_test.py6183%13
   init_test.py8188%16
   line_of_sight_test.py65494%147–150
   thermal_model_test.py30197%63
   visualization_test.py20195%31
paseos/utils
   check_cfg.py611870%31, 40, 46, 62–64, 71, 74–76, 79–81, 84–86, 101, 106
   operations_monitor.py71494%88, 129–132
paseos/visualization
   animation.py18667%27–30, 35, 44
   plot.py9367%28–31
   space_animation.py1952090%135, 159, 162–165, 171, 283, 308–310, 315, 325–326, 330, 365, 371–372, 405, 421–432
TOTAL183116191% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 1m 4s ⏱️

Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me except one very minor request. I tested it, and it seems working.
About flake I would leave 127 chars, otherwise it becomes very annoying.

paseos/tests/custom_property_test.py Outdated Show resolved Hide resolved
Co-authored-by: Gabriele Meoni <70584239+GabrieleMeoni@users.noreply.github.com>
@gomezzz
Copy link
Collaborator Author

gomezzz commented Jun 19, 2023

@GabrieleMeoni

About flake I would leave 127 chars, otherwise it becomes very annoying.

But then we should reformat because before we agreed on 100 and most of the repo is in 100 but now some parts are 127. So you will have a lot of formatting changes either ways because it is now inconsistent.

I would suggest to create an issue to either:

  • format repo to 127
  • format to 100 and change flake

@GabrieleMeoni GabrieleMeoni mentioned this pull request Jun 22, 2023
Merged
1 task
@gomezzz gomezzz merged commit e80b285 into main Jun 22, 2023
@gomezzz gomezzz deleted the custom-actor-properties branch June 22, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature implementing a new feature physical-model All things involving some physical models tests Anything related to the tests user-facing Anything that users can interact with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants