-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground station implementation #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to test it, but I would like to understand it better first.
@GabrieleMeoni I am waiting on a review of this if you find a second 🙏 (starting to accumulate a lot of PRs :D ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works fine for me, but I would add:
-) Comments to explain the rationale of tests (at a first glance, satellites with 0 velocity are weird. Also, it is not immediate to understand why satellites becomes visible over time).
-) Test to check GS visibility with non-zero satellite velocity. Maybe S2 (tle are notes and GS positions should be retrievable) and check how long the satellite is visible. This should give us a reasonable Ground-truth.
Do you have this data? I don't have it, especially the altitude angle at which the station are able to talk to S2 and window length I can't find online and I don't wanna spend hours searching. |
Added test for groundstation window length |
- More logging - New test for reality check
Description
Summary of changes
Resolved Issues
How Has This Been Tested?
Related Pull Requests
N/A